Repository navigation
pofile: Unescape the C escapes GNU gettext writes - #1425
Merged
Merged
Conversation
GNU xgettext and msgcat write BEL, BS, FF and VT inside PO strings as \a, \b, \f and \v. read_po only decoded \n, \r, \t, \\ and \", so these four stayed as a backslash and a letter, and a catalog compiled by Babel looked the message up under the wrong msgid. Signed-off-by: Christopher Krah <48338417+chrikrah@users.noreply.github.com>
akx
approved these changes
Nov 4, 2026
akx
left a comment
akx
left a comment
Member
There was a problem hiding this comment.
Expanding the list of escaped characters to match a couple more usual suspects. Sure.
akx
enabled auto-merge (squash)
November 4, 2026 06:07
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1425 +/- ##
==========================================
+ Coverage 93.57% 93.61% +0.03%
==========================================
Files 27 27
Lines 4951 4946 -5
==========================================
- Hits 4633 4630 -3
+ Misses 318 316 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PO strings use C escapes (GNU manual); xgettext writes VT as
\v, likewise\a,\b,\f.read_pokeeps these as two characters, so Babel's.momisses the translation. No issue exists.escape()has the same gap:write_ponow emits a raw VT, not\v. I'd fix it here with a round-trip test, skipping octal and\x. OK?